silencing non-exhaustive switch warning #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinseanmartin
approved these changes
Jul 30, 2024
RoyalPineapple
force-pushed
the
alex/FixError
branch
from
26ea254 to
28d5913
Compare
RoyalPineapple
force-pushed
the
alex/FixError
branch
from
f213ff6 to
2e64f21
Compare
SimoncelloCT
added a commit
to SimoncelloCT/KIF
that referenced
this pull request
Aug 21, 2024
* silencing non-exhaustive switch warning (kif-framework#1297) silencing non-exhaustive switch warning * Adding support for accessibility custom actions (kif-framework#1295) * adding support for accessibility custom actions * introduce tryFindingViewInFrame - avoid scroll when looking for a view visibility * remove wrong comment * improve comments * add missing disableScroll argument * introduce usingCurrentFrame() method on KIFUIViewTestActor to disable automatic scroll if needed * fixes: - fix wrong parameter name in comments - add missing methods - add missing things that prevent us to build for tests * fix to scrollView behavior: - with scrollDisabled = YES it now consider only views visible in the current frame, as it was done with TableView and CollectionViews - make explicit the scrollDisabled argument in recursive calls = NO when we are inside the scrolling section * add new integration tests for tryFindingViewInFrameWithAccessibilityIdentifier() and usingCurrentFrame() * Fix bug that was considering an occluded view as tappable * simplify boolean check and add integration test for broken case * Revert "simplify boolean check and add integration test for broken case" This reverts commit 6827225. * simplify boolean logic of the tappable check * add missing fromRootView argument Co-authored-by: Justin Martin <jmartin@squareup.com> * Change duplicated accessibilityLabel that was causing flakiness for 2 tests --------- Co-authored-by: Alex Odawa <aodawa@squareup.com> Co-authored-by: Simone Scionti <simone.scionti@qonto.com> Co-authored-by: Justin Martin <jmartin@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.