Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need a builder for AWSElasticCacheClient? #55

Closed
dkador opened this issue Mar 7, 2017 · 4 comments
Closed

need a builder for AWSElasticCacheClient? #55

dkador opened this issue Mar 7, 2017 · 4 comments

Comments

@dkador
Copy link

dkador commented Mar 7, 2017

hello!

thank you for providing support for node autodiscovery in AWS elasticache. i just tested it out and it looks like it's working so far. if our testing continues to go well, it means we won't have to run twemproxy, which is nice!

in my testing i ran into what might be a configuration/building issue. but i'm new to xmemcached, so perhaps i'm not using it right. basically, i want to be able to set configuration values such as setConnectionPoolSize. in our existing code in master, we use the builder pattern given to us via XMemcachedClientBuilder. but AWSElasticCacheClient doesn't have an associated builder.

so i instantiated it manually and tried to call setConnectionPoolSize, but that gives me an IllegalStateError as the constructor for AWSElasticCacheClient starts the connection.

i also want to set the session idle timeout: builder.getConfiguration().setSessionIdleTimeout(15000);

do you have any suggestions for how i can make this work? or do we need a new version that either gives us a builder for AWSElasticCacheClient or, perhaps, allows us to not start the AWSElasticCacheClient at instantiation time but instead manually?

thanks again!

@killme2008
Copy link
Owner

hi, it's a defect here, it should provide a builder for AWSElasticCacheClient, thanks for your proposal, i will add it ASAP.

@dkador
Copy link
Author

dkador commented Mar 7, 2017

thanks for the prompt reply! very much appreciated.

@killme2008
Copy link
Owner

Released 2.3.1, but it may take some time to be synchronized into central repository.

You can download the jar from

https://github.com/killme2008/xmemcached/releases/tag/xmemcached-2.3.1

@dkador
Copy link
Author

dkador commented Mar 17, 2017

thank you for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants