-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leak caused by HealthCheckHandler function #190
Labels
bug
Something isn't working
Comments
Thank you for noticing this. :) |
kimdre
added a commit
that referenced
this issue
Nov 5, 2024
The fix is released with v0.12.2 |
You're welcome. Thanks for your app, it's a great gitops CD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @kimdre,
When I deployed and handled a high volume of commits to git within a time frame, I noticed that the agent memory usage increased abnormally.
`
After checking the code, I found that the HealthCheckHandler() function includes a segment that checks the Docker socket connection via the VerifySocketConnection() function. In this function, the httpClient instance is created but not closed after use.
httpClient := NewHttpClient()
When I added code to ensure the httpClient is released after use.
defer httpClient.CloseIdleConnections()
It worked. Memory usage is now stable, with no further unexpected increases.
Please check this again.
The text was updated successfully, but these errors were encountered: