[Maps] Migrate Maps embeddables to NP (elastic#63976)

* Migrate maps embeddables. Clean up legacy presence * Fix type error Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kindsun · Apr 23, 2020 · a5ad497 · a5ad497
1 parent c42a2d0
commit a5ad497
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 33 deletions.
diff --git a/x-pack/legacy/plugins/maps/index.js b/x-pack/legacy/plugins/maps/index.js
@@ -57,7 +57,6 @@ export function maps(kibana) {
           tilemap: _.get(mapConfig, 'tilemap', []),
         };
       },
-      embeddableFactories: ['plugins/maps/embeddable/map_embeddable_factory'],
       styleSheetPaths: `${__dirname}/public/index.scss`,
       savedObjectSchemas: {
         'maps-telemetry': {

diff --git a/x-pack/legacy/plugins/maps/public/embeddable/map_embeddable_factory.ts b/x-pack/legacy/plugins/maps/public/embeddable/map_embeddable_factory.ts
diff --git a/x-pack/plugins/maps/kibana.json b/x-pack/plugins/maps/kibana.json
@@ -5,12 +5,14 @@
   "configPath": ["xpack", "maps"],
   "requiredPlugins": [
     "inspector",
+    "licensing",
     "home",
     "data",
     "fileUpload",
     "uiActions",
     "navigation",
-    "visualizations"
+    "visualizations",
+    "embeddable"
   ],
   "ui": true
 }
diff --git a/x-pack/plugins/maps/public/plugin.ts b/x-pack/plugins/maps/public/plugin.ts
@@ -39,11 +39,15 @@ import { getMapsVisTypeAlias } from './maps_vis_type_alias';
 import { HomePublicPluginSetup } from '../../../../src/plugins/home/public';
 import { VisualizationsSetup } from '../../../../src/plugins/visualizations/public';
 import { registerLayerWizards } from './layers/load_layer_wizards';
+import { MAP_SAVED_OBJECT_TYPE } from '../common/constants';
+import { MapEmbeddableFactory } from './embeddable';
+import { EmbeddableSetup } from '../../../../src/plugins/embeddable/public';
 
 export interface MapsPluginSetupDependencies {
   inspector: InspectorSetupContract;
   home: HomePublicPluginSetup;
   visualizations: VisualizationsSetup;
+  embeddable: EmbeddableSetup;
 }
 // eslint-disable-next-line @typescript-eslint/no-empty-interface
 export interface MapsPluginStartDependencies {}
@@ -102,12 +106,13 @@ export class MapsPlugin
       MapsPluginStartDependencies
     > {
   public setup(core: CoreSetup, plugins: MapsPluginSetupDependencies) {
-    const { inspector, home, visualizations } = plugins;
+    const { inspector, home, visualizations, embeddable } = plugins;
     bindSetupCoreAndPlugins(core, plugins);
 
     inspector.registerView(MapView);
     home.featureCatalogue.register(featureCatalogueEntry);
     visualizations.registerAlias(getMapsVisTypeAlias());
+    embeddable.registerEmbeddableFactory(MAP_SAVED_OBJECT_TYPE, new MapEmbeddableFactory());
   }
 
   public start(core: CoreStart, plugins: any) {