WIP - Development #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 1, 2021 14:10
yarn global add cdk8s-cli
$GIT_REPO - variable for development purposes it will be handy to be able to swap out this git repository easily from here in the script, so let's make it a variable parameter in the script. Was on the fence about running: cdk8s import k8s inside of CI, opted to run it upstream intead. npm run compile will succeed as long as k8s.ts is included tests are used to ensure smoke-test readiness but are not comprehensive * add package-lock.json - there is an error from CI about npm version * Generally do not commit synths/*.js (except for synths/jest.config.js, which is full of test configuration) * do not include compilation targets Generated by npm run compile and they should not be committed in CI * do not save __snapshots__/*.test.ts.snap I am not sure how snapshots work but they are recommended as a test strategy in the distro files from cdk8s. I do not know how jest works outside of basic things, will use it to write some tests maybe, or skip it. (It would be better to test this with something comprehensive before it is applied to the cluster, but maybe kustomization's health checking is good enough to avoid a complex suite of tests upstream...) https://openconstructfoundation.org/testing-cdk8s/ So we can see a problem in our generated output thanks to test failures, the namespace has not been mentioned in the re-hydrated yaml from cdk8s. Let's add a test that asserts we include the namespace, and include it. * run the tests in CI this should stop synths commit from being generated in event that it failed the test (this is imperfect, but it's a useful mitigation) * do not use snapshots for now
|
This needs to be rebased and squashed with a signature to merge (closing) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits on the development branch are automatically deployed through Jenkins