Skip to content

Commit

Permalink
Treat artifact registry as gcr.io registry
Browse files Browse the repository at this point in the history
If the Workload Identity is set up correctly and the role for artifact
registry is assigned (roles/artifactregistry.reader) artifact registry
also works. 👍

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
  • Loading branch information
Kingdon Barrett committed Jan 14, 2022
1 parent d5c32fc commit 2eb0be8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion controllers/imagerepository_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -733,5 +733,5 @@ func hostIsAzureContainerRegistry(host string) bool {
}

func hostIsGoogleContainerRegistry(host string) bool {
return host == "gcr.io" || strings.HasSuffix(host, ".gcr.io")
return host == "gcr.io" || strings.HasSuffix(host, ".gcr.io") || strings.HasSuffix(host, "-docker.pkg.dev")
}

0 comments on commit 2eb0be8

Please sign in to comment.