Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimising sound dynamics #607

Closed
JeremTM93 opened this issue Nov 4, 2023 · 12 comments
Closed

Optimising sound dynamics #607

JeremTM93 opened this issue Nov 4, 2023 · 12 comments

Comments

@JeremTM93
Copy link

When we compare the sound of KSplayer with MPV on tvOS (LillyPlayer, Plex...) or ExoPlayer on Android TV, the sound is not the same:

-Sound dynamics are deficient overall, regardless of the multichannel sound tracks played.
-Some surround effects between the speakers are absent.
-The subwoofer's bass reproduction is not at the expected level (underpowered).

You can help yourself with the film "ready player one" in Atmos TrueHD, and more particularly the scene from 12:40 to 13:30 of the film.

@djokt
Copy link

djokt commented Nov 4, 2023

I can confirm. It's as if the sound were limited or lacking in power.

@cdguy
Copy link

cdguy commented Nov 4, 2023

When we compare the sound of KSplayer with MPV on tvOS (LillyPlayer, Plex...) or ExoPlayer on Android TV, the sound is not the same:

-Sound dynamics are deficient overall, regardless of the multichannel sound tracks played. -Some surround effects between the speakers are absent. -The subwoofer's bass reproduction is not at the expected level (underpowered).

You can help yourself with the film "ready player one" in Atmos TrueHD, and more particularly the scene from 12:40 to 13:30 of the film.

https://www.imdb.com/title/tt1677720/

kingslay added a commit that referenced this issue Nov 4, 2023
@kingslay
Copy link
Owner

kingslay commented Nov 4, 2023

@JeremTM93 我先简单的增加了一个音频输出,AudioUnit。 你可以到demo app的设置/音频。进行选择。这个音频输出做的还比较简单,无法静音和倍数播放。但是你可以用它来实验下你说的问题。看下有没有改善。这个音频输出我是仿照mpv来写的,看下能否达到跟mpv一样的效果

@cdguy
Copy link

cdguy commented Nov 4, 2023

@JeremTM93 我先简单的增加了一个音频输出,AudioUnit。 你可以到demo app的设置/音频。进行选择。这个音频输出做的还比较简单,无法静音和倍数播放。但是你可以用它来实验下你说的问题。看下有没有改善。这个音频输出我是仿照mpv来写的,看下能否达到跟mpv一样的效果

You have to update the testflight app, @JeremTM93 is not a developper

@JeremTM93
Copy link
Author

@JeremTM93 我先简单的增加了一个音频输出,AudioUnit。 你可以到demo app的设置/音频。进行选择。这个音频输出做的还比较简单,无法静音和倍数播放。但是你可以用它来实验下你说的问题。看下有没有改善。这个音频输出我是仿照mpv来写的,看下能否达到跟mpv一样的效果

Indeed, there is a real difference in dynamics with the “AudioUnit” option. I need more time to compare correctly but you are on the right track I think 🙏👌

@JeremTM93
Copy link
Author

We agree @kingslay , you also feel a big difference ?

@cdguy
Copy link

cdguy commented Nov 5, 2023

The sound difference is amazing!! AudioUnit shouls be the default “audio framework” for Ksplayer! I advise you to push a commit for that. This thread can be closed!! 🥳🥳

@kingslay
Copy link
Owner

kingslay commented Nov 5, 2023

AudioUnit 是直接把音频输出到音响的,中间少了很多处理。所以效果是会最好的。但是这样的话,也就只有播放、暂停、静音的功能。没有倍数播放,音量调节,AudioDynamicsProcessor相关功能。

@cdguy
Copy link

cdguy commented Nov 5, 2023

AudioUnit 是直接把音频输出到音响的,中间少了很多处理。所以效果是会最好的。但是这样的话,也就只有播放、暂停、静音的功能。没有倍数播放,音量调节,AudioDynamicsProcessor相关功能。

@kingslay for multi stream playback (so more than 2 streams played on a split screen) VLC is always the safest option

@cdguy
Copy link

cdguy commented Nov 5, 2023

AudioUnit 是直接把音频输出到音响的,中间少了很多处理。所以效果是会最好的。但是这样的话,也就只有播放、暂停、静音的功能。没有倍数播放,音量调节,AudioDynamicsProcessor相关功能。

And perhaps mentioning what you just said, in the read me file (welcome page), would help new people willing to use KsPlayer

@JeremTM93
Copy link
Author

JeremTM93 commented Nov 5, 2023

The sound dynamics are the same as with the MPV player or exoplayer, this subject can indeed be closed. nice work @kingslay.

@cdguy
Copy link

cdguy commented Nov 7, 2023

@kingslay do not forget to close this thread

theonlymo pushed a commit to theonlymo/KSPlayer that referenced this issue Nov 16, 2023
* 'develop' of github.com:kingslay/KSPlayer:
  add videoBitrate and audioBitrate
  add Stream Type kingslay#528
  解决AirPods 的问题
  fix kingslay#609
  fix kingslay#602
  AudioUnitPlayer add mute
  add AudioUnitPlayer kingslay#607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants