Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dolby Vision no longer detected #621

Closed
JeremTM93 opened this issue Nov 6, 2023 · 6 comments
Closed

Dolby Vision no longer detected #621

JeremTM93 opened this issue Nov 6, 2023 · 6 comments

Comments

@JeremTM93
Copy link

A Dolby Vision stream I was playing with TracyPlayer version 36 now plays in HDR10. However, this stream is actually in DV

@cdguy
Copy link

cdguy commented Nov 6, 2023

A Dolby Vision stream I was playing with TracyPlayer version 36 now plays in HDR10. However, this stream is actually in DV

This is the commit that broke it:

https://github.com/kingslay/KSPlayer/commits/develop

before this commit, HDR10 content was always displayed in DV, and now on the contrary after this commit, all content is displayed in HDR10

@JeremTM93
Copy link
Author

A Dolby Vision stream I was playing with TracyPlayer version 36 now plays in HDR10. However, this stream is actually in DV

This is the commit that broke it:

https://github.com/kingslay/KSPlayer/commits/develop

before this commit, HDR10 content was always displayed in DV, and now on the contrary after this commit, all content is displayed in HDR10

#615 ?

I don't understand, isn't HDR HLG just for live streams ?

@kingslay
Copy link
Owner

kingslay commented Nov 6, 2023

可以提供下url吗?

@cdguy
Copy link

cdguy commented Nov 6, 2023

可以提供下url吗?

I will send you a few DV movies link via e-mail

@cdguy
Copy link

cdguy commented Nov 7, 2023

@kingslay looking at your last commit, I don’t know if it might help:
Real 4K live streams/DV content/HDR/HDR10+ are always progressive. As per the live satellite broadcast standards and movie production , those content wouls never be in interlaced format

@kingslay
Copy link
Owner

kingslay commented Nov 7, 2023

是的,这个其实跟interlaced没有关系,只是因为现在interlaced的逻辑,我们已经真正实现了。所以我顺便把interlaced 的逻辑从MEOptions移到KSOptions。这样所以这个库的人都能用到了。一些实验的功能,我会先在MEOptions实验。等打磨好了。在放到KSOptions。其实这个改动的核心点是 override func updateVideo(refreshRate: Float, isDovi: Bool, formatDescription: CMFormatDescription?) {
专门传递了isDovi 这个信息。因为从CMFormatDescription是无法判断是不是isDovi的。

theonlymo pushed a commit to theonlymo/KSPlayer that referenced this issue Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants