chore: Upgrade Gradle to 8.5 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`./gradlew assemble --scan --warning-mode all` ` ./gradlew wrapper --gradle-version 8.5 --distribution-type all --gradle-distribution-sha256-sum=c16d517b50dd28b3f5838f0e844b7520b8f1eb610f2f29de7e4e04a1b7c9c79b` Per build scan ``` neonmarker assemble Dec 8 2023 10:15:56 EST This build did not contain any deprecations. ``` Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
|
@thc202 look right? |
|
Looks good! |
|
Thanks! |
|
@thc202 I should have asked. Should I be changing any of the spotless setup/handling or using features from https://github.com/zaproxy/gradle-plugin-add-on ? |
|
They can be definitely updated to get the latest changes but it will not save many configs, in this case only this line can be removed after the updates: Line 53 in d131d7f |
|
Okay I'll leave it as-is for now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./gradlew assemble --scan --warning-mode all./gradlew wrapper --gradle-version 8.5 --distribution-type all --gradle-distribution-sha256-sum=c16d517b50dd28b3f5838f0e844b7520b8f1eb610f2f29de7e4e04a1b7c9c79bPer build scan