Allow users to choose the name strategy of fields #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 99 108 +9
Branches 15 16 +1
=========================================
+ Hits 99 108 +9 ☔ View full report in Codecov by Sentry. |
|
Just pending unit tests, changelog entry, docs. Tested with the sample protobuf from the docs. protobuf_uml_diagram.py --proto test_data/issue_10.proto --output /tmp
#or
protobuf_uml_diagram.py --proto test_data/issue_10.proto --output /tmp --full_names=true
$ protobuf_uml_diagram.py --proto test_data/issue_10.proto --output /tmp --full_names=False
The difference is the new parameter |
kinow
force-pushed
the
allow-users-to-choose-name-strategy
branch
from
9a5ea96
to
77aae0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #78 related to #75
In #10 we changed how names of fields were chosen, as there could be fields with the same name, but that meant/were different things. Instead, we started using the field full name (i.e.
Airplace.wing,Chicken.winginstead of justwing).In this pull request we allow users to change that behavior if they are sure that will not cause any issues, or if they prefer for aesthetics.
Thanks to @danjohles for reporting it.
-Bruno