This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
[WIP] Add parent span argument to SpanProcessor.OnStart #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this needs more discussion in the issue. Currently what we pass to the processor is a Other than that, the changes look ok, but they show that for now this parent span context is rather useless. I suppose that the batch span processor should actually be doing something with it… |
johananl
force-pushed
the
johananl/onstart-parent-context
branch
from
d7f6512 to
bbdc7c9
Compare
johananl
force-pushed
the
johananl/onstart-parent-context
branch
from
81f033e to
c9b800c
Compare
The spec requires having this argument in OnStart.
According to the spec, OnStart and OnEnd should accept a span object which is represented by the otel.Span interface in the Go library. Right now we are passing a *export.SpanData struct to these methods which is an SDK-internal struct.
When using the API we can't rely on attributes to determine the order of span processors because SetAttributes overwrites attributes when a for existing keys, which results in keeping only the attribute set by the last span processor. Before this change it was possible to use attributes to determine span processor order because the tests wrote to the attributes slice directly rather than via the SetAttributes API method. Use events as a wrapper around attributes instead.
johananl
force-pushed
the
johananl/onstart-parent-context
branch
from
c9b800c to
a8563f2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.