Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping: Create Cookbook example story for Form Field #3731

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Housekeeping: Create Cookbook example story for Form Field #3731

merged 5 commits into from
Dec 5, 2024

Conversation

RasmusKjeldgaard
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard commented Dec 5, 2024 •
edited
Loading

Which issue does this PR close?

This PR adds visual regression testing for form-field via all the cookbook examples.

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@RasmusKjeldgaard RasmusKjeldgaard added the ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby label Dec 5, 2024
@RasmusKjeldgaard RasmusKjeldgaard self-assigned this Dec 5, 2024
@RasmusKjeldgaard RasmusKjeldgaard merged commit 472f9ae into develop Dec 5, 2024
10 of 12 checks passed
@RasmusKjeldgaard RasmusKjeldgaard deleted the enhancement/form-field-cookbook-example-story branch December 5, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobe jakobe jakobe approved these changes

Assignees

@RasmusKjeldgaard RasmusKjeldgaard

Labels
ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby
Projects
Kirby
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RasmusKjeldgaard @jakobe