Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: fix wrong date when using keyboard nav and UTC timezone #3744

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

RasmusKjeldgaard
Copy link
Collaborator

Which issue does this PR close?

This PR closes #3743

What is the new behavior?

We normalize the date before setting focussed date, to ensure that timezone difference between local and utc time does not affect focussed day.

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@RasmusKjeldgaard RasmusKjeldgaard added the fix Add this PR to the changelog as a bugfix label Dec 18, 2024
Copy link
Collaborator

@Fuzzy3 Fuzzy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun stuff - simple solution ❤️

@RasmusKjeldgaard RasmusKjeldgaard merged commit 27d1f36 into develop Dec 18, 2024
12 checks passed
@RasmusKjeldgaard RasmusKjeldgaard deleted the bug/3743-calendar-utc-wrong-focussed-date branch December 18, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Calendar with UTC timezone sometimes calculates wrong focussed date
2 participants