Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAIN] KAV-353: SDK Update Lat Lng Request Pickup #33

Merged
merged 2 commits into from
Nov 15, 2023
Merged

[MAIN] KAV-353: SDK Update Lat Lng Request Pickup #33

merged 2 commits into from
Nov 15, 2023

Conversation

Inabiel
Copy link
Contributor

@Inabiel Inabiel commented Jul 15, 2023

No description provided.

@Inabiel Inabiel self-assigned this Jul 15, 2023
@jira-ticket-bot
Copy link

https://kiriminaja.atlassian.net/browse/KAV-353

@instapr
Copy link

instapr bot commented Jul 15, 2023

Feedback:

  • It seems like you have added two new properties latitude and longitude to the RequestPickupData class. Be sure to update the class documentation to explain their purpose and usage.
  • Double-check the typo in the comment for the longitude property. It should say "Longitude dari pengirim, diperlukan ketika menggunakan ekspedisi Lion Parcel."

@yanuaraditia yanuaraditia merged commit 145b339 into main Nov 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GontangRagilPrakasa GontangRagilPrakasa Awaiting requested review from GontangRagilPrakasa

Assignees

@Inabiel Inabiel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Inabiel @yanuaraditia