Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert scripts to the format used by console_scripts #493

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

segevfiner
Copy link
Contributor

@kislyuk

Split from #474

@segevfiner
Copy link
Contributor Author

ruff seems to have made a backwards incompatible change that broke your CI.

@segevfiner
Copy link
Contributor Author

@kislyuk Did you look at this? Want me to make a separate PR to fix CI?

Copy link
Owner

@kislyuk kislyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@segevfiner thanks for your contribution, but can you please change the git history such that the move is explicitly reflected? In other words, git mv the files from one place to the other, then add new files in their place with no commonality with the original files.

I can't review this PR as it is because there is no diff reflecting any changes (or lack thereof) made in the move.


import argcomplete

__package__ = "argcomplete"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this set? Please either document a reason why this needs to be set in a comment, or remove this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment

@segevfiner
Copy link
Contributor Author

@segevfiner thanks for your contribution, but can you please change the git history such that the move is explicitly reflected? In other words, git mv the files from one place to the other, then add new files in their place with no commonality with the original files.

I can't review this PR as it is because there is no diff reflecting any changes (or lack thereof) made in the move.

Just an FYI: A git mv is just a git rm + git add of the new file. There is no special metadata saved in Git about moves, it's always a heuristic. So you might still need to review the individual commits.

@segevfiner
Copy link
Contributor Author

@kislyuk Fixes committed.

@kislyuk kislyuk merged commit 368bc32 into kislyuk:develop Aug 2, 2024
0 of 22 checks passed
@kislyuk
Copy link
Owner

kislyuk commented Aug 2, 2024

Thanks, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants