Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support regexp and prefix match #21

Merged
merged 7 commits into from
Dec 23, 2023
Merged

Conversation

whalecold
Copy link
Member

What type of PR is this?

feat

What this PR does / why we need it (en: English/zh: Chinese):

en:
zh:

Which issue(s) this PR fixes:

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2023

CLA assistant check
All committers have signed the CLA.

@whalecold whalecold changed the title feat: support regexp and prefix match WIP: feat: support regexp and prefix match Dec 12, 2023
@whalecold whalecold changed the title WIP: feat: support regexp and prefix match feat: support regexp and prefix match Dec 12, 2023
@ppzqh
Copy link
Contributor

ppzqh commented Dec 13, 2023

thanks. I will review this later

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ppzqh, whalecold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@li-jin-gou li-jin-gou merged commit 1fb0e15 into kitex-contrib:main Dec 23, 2023
10 of 11 checks passed
@whalecold whalecold deleted the test branch December 25, 2023 02:49
whalecold added a commit to whalecold/xds that referenced this pull request Dec 28, 2023
* feat: support regexp and prefix match

* fix uint test

* fix uint test

* remove useless println

* tweak log

* tweak field

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants