fix(retry): fix the retry policy do not take affect #33
+334
−1,352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can extent the retryer to use router logic and do the retry based on retry policy from RDS. |
whalecold
changed the title
Fixed, I will test in actual environment later |
ok👍 |
ppzqh
reviewed
Aug 29, 2024
ppzqh
reviewed
Aug 29, 2024
ppzqh
reviewed
Aug 29, 2024
ppzqh
reviewed
Aug 29, 2024
whalecold
force-pushed
the
fix/retry
branch
3 times, most recently
from
a9388ea
to
cee5056
Compare
ppzqh
reviewed
Sep 4, 2024
ppzqh
approved these changes
Sep 6, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ppzqh, whalecold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it (en: English/zh: Chinese):
The logic of retry is before the router, the value of key RouterClusterKey can't be found, add a new router object to the retry policy manager, use the router to acquire the RouterClusterKey.
en:
zh:
Which issue(s) this PR fixes: