Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerability caused by filename escaping #877

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

motoyasu-saburi
Copy link

@motoyasu-saburi motoyasu-saburi commented Oct 2, 2023

Detail:
#876

Local tests have not yet been run.
(I need to set up the Android-SDK perimeter, which is taking a bit of time.)

@motoyasu-saburi motoyasu-saburi changed the title [WIP] Fix vulnerability caused by filename escaping Fix vulnerability caused by filename escaping Oct 2, 2023
@kittinunf
Copy link
Owner

Hey thanks so much for the fix! I will take a look on this tonight.

Copy link
Owner

@kittinunf kittinunf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request, otherwise this looks good 👍

@motoyasu-saburi
Copy link
Author

@kittinunf Thank you for your review 🙇
Could you review it again?

@kittinunf kittinunf merged commit c6cf4a6 into kittinunf:2.x Oct 13, 2023
@kittinunf
Copy link
Owner

@motoyasu-saburi I will release the patch for this soon please hang on tight.

@motoyasu-saburi motoyasu-saburi deleted the 2.x branch October 23, 2023 11:56
@Shpota
Copy link

Shpota commented Dec 4, 2023

@kittinunf thank you for the library. When are you planing to push the v2 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants