Merge pull request #5151 from kiva/vue-worker-set-cookie-fix

fix: set cookie headers not being added to response

server/vue-worker.js

@@ -47,22 +47,23 @@ async function render(context) {
 			}
 		});
 
-	const setCookies = [];
+	let setCookies = [];
 
 	return Promise.all([typesPromise, cookiePromise])
 		.then(([types, cookieInfo]) => {
 			// add fetched types to rendering context
 			context.config.graphqlPossibleTypes = types;
 			// update cookies in the rendering context with any newly fetched session cookies
 			context.cookies = Object.assign(context.cookies, cookieInfo.cookies);
-			// forward any newly fetched 'Set-Cookie' headers
-			context.setCookies = [...cookieInfo.setCookies];
+			// collect any newly fetched 'Set-Cookie' headers to send after the render
+			setCookies = [...cookieInfo.setCookies];
 			// render the app
 			return renderer.renderToString(context);
 		})
 		.then(html => {
 			// collect any cookies created during the app render
-			setCookies.concat(context.setCookies);
+			const contextSetCookies = context?.setCookies ?? [];
+			setCookies = [...setCookies, ...contextSetCookies];
 			// send the final rendered html
 			return {
 				html,
@@ -71,7 +72,8 @@ async function render(context) {
 		})
 		.catch(err => {
 			// collect any cookies created during the app render
-			setCookies.concat(context.setCookies);
+			const contextSetCookies = context?.setCookies ?? [];
+			setCookies = [...setCookies, ...contextSetCookies];
 			// send the error
 			return {
 				error: err,