Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add campaign progress bar to category page #5160

Merged

Conversation

dyersituations
Copy link
Collaborator

@dyersituations dyersituations commented Feb 8, 2024

https://kiva.atlassian.net/browse/CORE-1724

  • Updated the campaign progress bar to match the updated mocks + data
  • Moved the IWD header into its own file
  • Created a wrapper component for the shared progress bar usage
  • Added the bar to the category page for IWD
  • Small fix for padding on thanks page from previous PR

image

image

UPDATE

  • Added the progress bar to the thanks page variations for IWD
  • Created minimal version of the progress bar

image

image

image

image

@dyersituations dyersituations requested a review from a team February 8, 2024 01:26
Copy link
Collaborator

@mcstover mcstover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a release planned today, we'll need to keep an eye on those missing queries... If active on server render they could fail the page load. Should break more gracefully if only in the client.

@dyersituations
Copy link
Collaborator Author

With a release planned today, we'll need to keep an eye on those missing queries... If active on server render they could fail the page load. Should break more gracefully if only in the client.

@mcstover Good call. The monolith is going out, so I think we should be OK. Also the new fields added to the server-side call are all existing fields. The new queries are called on mount. But just in case I wrapped the activity feed query in a try catch, because we weren't catching exceptions before. The other new stats query is already wrapped in a try catch. In the process I noticed that we were actually pulling the wrong campaign for the activity feed, so I updated that as well!

@dyersituations dyersituations merged commit 6c6af72 into main Feb 8, 2024
5 checks passed
@dyersituations dyersituations deleted the CORE-1724-add-campaign-progress-bar-to-category-page branch February 8, 2024 19:56
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.730.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.730.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants