-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add campaign progress bar to category page #5160
feat: add campaign progress bar to category page #5160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a release planned today, we'll need to keep an eye on those missing queries... If active on server render they could fail the page load. Should break more gracefully if only in the client.
@mcstover Good call. The monolith is going out, so I think we should be OK. Also the new fields added to the server-side call are all existing fields. The new queries are called on mount. But just in case I wrapped the activity feed query in a try catch, because we weren't catching exceptions before. The other new stats query is already wrapped in a try catch. In the process I noticed that we were actually pulling the wrong campaign for the activity feed, so I updated that as well! |
🎉 This PR is included in version 2.730.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.730.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
https://kiva.atlassian.net/browse/CORE-1724
UPDATE