Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: time sensitive change copy and link on challenge ty page #5161

Merged
merged 3 commits into from
Feb 9, 2024
Merged

feat: time sensitive change copy and link on challenge ty page #5161

merged 3 commits into from
Feb 9, 2024

Conversation

dyersituations
Copy link
Collaborator

https://kiva.atlassian.net/browse/ACK-991

  • Changes requested for the header shown on the Thanks page for team challenge participants
  • For now this won't be shown in over the IWD header, but that is a known limitation
  • Changes are ready for pre/post-IWD
  • Refactored the old component as needed
  • Also added a couple fixes to the activity feed: 1) limited to 6 items returned, 2) added missing id field

image

@dyersituations dyersituations requested a review from a team February 8, 2024 22:54
mcstover
mcstover approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@mcstover mcstover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's on!

@dyersituations dyersituations merged commit e62c313 into main Feb 9, 2024
5 checks passed
@dyersituations dyersituations deleted the ACK-991-time-sensitive-change-copy-and-link-on-challenge-ty-page branch February 9, 2024 00:07
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.730.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.730.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@xumical xumical mentioned this pull request Feb 18, 2024
Open
@xumical xumical mentioned this pull request Apr 16, 2024
Open
@xumical xumical mentioned this pull request Apr 29, 2024
Open
@xumical xumical mentioned this pull request May 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcstover mcstover mcstover approved these changes

Assignees
No one assigned
Labels
released on @staging released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dyersituations @kiva-robot @mcstover