Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken reflink callback updates & big cleanup. #438

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

kivikakk
Copy link
Owner

@kivikakk kivikakk commented Jul 11, 2024

Fixes #143.

This PR moves the callback into the ParserOptions struct (which now takes a lifetime), and deprecates parse_document_with_broken_link_callback. It also cleans up the docs and some types in general.

Copy link
Contributor

Command Mean [ms] Min [ms] Max [ms] Relative
./bench.sh ./comrak-20a054b 328.5 ± 4.0 321.3 336.4 2.89 ± 0.05
./bench.sh ./comrak-main 334.1 ± 5.3 325.8 352.9 2.94 ± 0.06
./bench.sh ./pulldown-cmark 113.6 ± 1.3 111.2 116.1 1.00
./bench.sh ./cmark-gfm 121.5 ± 1.5 119.2 125.4 1.07 ± 0.02
./bench.sh ./markdown-it 502.3 ± 2.6 497.1 508.1 4.42 ± 0.05

Run on Thu Jul 11 12:45:33 UTC 2024

@kivikakk kivikakk changed the title mod: broken link reference callback gets normalized and original. parser: broken link reference callback gets normalized and original. Jul 11, 2024
@kivikakk kivikakk changed the title parser: broken link reference callback gets normalized and original. broken reflink callback updates & big cleanup. Jul 11, 2024
@kivikakk kivikakk enabled auto-merge July 11, 2024 13:53
@kivikakk kivikakk merged commit 3bb6d4c into main Jul 11, 2024
39 checks passed
@kivikakk kivikakk deleted the broken-link-callback-cleanup branch July 11, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link callback gets passed normalised link labels
1 participant