Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore inline sourcepos as experimental. #444

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Restore inline sourcepos as experimental. #444

merged 2 commits into from
Jul 12, 2024

Conversation

kivikakk
Copy link
Owner

@github-actions GitHub Actions
Copy link
Contributor

Command Mean [ms] Min [ms] Max [ms] Relative
./bench.sh ./comrak-7e2c1ba 320.2 ± 2.4 317.4 330.4 2.92 ± 0.03
./bench.sh ./comrak-main 318.9 ± 1.5 316.1 323.2 2.90 ± 0.02
./bench.sh ./pulldown-cmark 109.8 ± 0.7 109.0 112.5 1.00
./bench.sh ./cmark-gfm 117.9 ± 0.5 117.1 119.1 1.07 ± 0.01
./bench.sh ./markdown-it 480.0 ± 14.3 475.0 548.1 4.37 ± 0.13

Run on Fri Jul 12 16:20:20 UTC 2024

@kivikakk
Copy link
Owner Author

@digitalmoksha Let me know if this looks good/sufficient for you, and then I'll release it as 0.26.0. :)

@kivikakk kivikakk marked this pull request as ready for review July 12, 2024 16:24
@digitalmoksha
Copy link
Collaborator

@kivikakk yeah that looks good. Thank you! 🙇 🙇 🙇

@kivikakk kivikakk merged commit 0de8251 into main Jul 12, 2024
40 checks passed
@kivikakk kivikakk deleted the experimental-inline-sourcepos branch July 12, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitalmoksha digitalmoksha Awaiting requested review from digitalmoksha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kivikakk @digitalmoksha