Enhance description lists #462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run on Mon Sep 2 17:20:02 UTC 2024 |
digitalmoksha
force-pushed
the
bw-description-lists
branch
from
127649b
to
3694ebe
Compare
digitalmoksha
commented
Sep 28, 2024
Comment on lines
+1856
to
+1875
| // ATTEMPT 1 | ||
| // reopen_ast_nodes(last_child); | ||
| // | ||
| // let details = | ||
| // self.add_child(last_child, NodeValue::DescriptionDetails, self.first_nonspace + 1); | ||
| // *container = details; | ||
| // | ||
| // true | ||
|
|
||
| // ATTEMPT 2 | ||
| // let parent = last_child.parent().unwrap(); | ||
| // let item = parent.last_child().unwrap(); | ||
| // | ||
| // reopen_ast_nodes(item); | ||
| // | ||
| // let details = | ||
| // self.add_child(item, NodeValue::DescriptionDetails, self.first_nonspace + 1); | ||
| // *container = details; | ||
| // | ||
| // true |
There was a problem hiding this comment.
@kivikakk I was wondering if you could take a look at this.
I realized that when supporting multiple definitions, the second DescriptionDetails gets added as an entirely new DescriptionItem, rather than being added as a child to the existing DescriptionItem.
But both my attempts to do this resulted in the assert!(ast.open); in finalize_borrowed tripping.
Sample input
foo
: bar
: one
I thought maybe it's the shenanigans I'm doing at line 1760, the None case, but using the following input (with blanks lines) bypasses that and it still asserts.
foo
: bar
: one
Even with re-opening the ast node, it's not working. I'm missing some magic incantation. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Enhancing description lists.
Add support for multiple description definitions
Allow for the definition to follow after the term without a blank line
Allow a definition list to be either "tight" or "loose", same as a normal list. Related to Description lists with tight and loose syntax #327
Waffling on this one. "Tight" and "loose" lists add complexity, and is not well understood by users. Most implementations I've seen do support the distinction. However not supporting it means styling the list would be easier and less complex. 🤷