Write a sourcepos test for each NodeValue variant
#498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of these are covered at the bottom of the specific test file, such as https://github.com/kivikakk/comrak/blob/main/src/tests/wikilinks.rs#L218-L276, though not everything is covered. So more coverage of this is super helpful. Yeah, there is still more work to do on getting inline sourcepos working consistently. |
|
How do you feel about the whole |
SamWilsn
force-pushed
the
sourcepos-tests
branch
from
be9fb71 to
12ebd94
Compare
SamWilsn
commented
Dec 6, 2024
Comment on lines
+398
to
+409
| List // end is 3:0 | ||
| | Item // end is 3:0 | ||
| | TaskItem // end is 4:0 | ||
| | DescriptionItem // end is 4:0 | ||
| | DescriptionTerm // end is 3:0 | ||
| | DescriptionDetails // end is 4:0 | ||
| | HtmlInline // end is 1:31 but should be 3:14 | ||
| | LineBreak // start is 1:15 but should be 1:13 | ||
| | Code // is 1:8-1:12 but should be 1:7-1:13 | ||
| | ThematicBreak // end is 4:0 | ||
| | Link // inconsistent between link types | ||
| | Math // is 3:2-3:6 but should be 3:1-3:7 |
There was a problem hiding this comment.
If y'all can confirm that all of these are bugs, I'll try my hand at fixing them.
There was a problem hiding this comment.
Yeah I think those are all incorrect sourcesos 😢
SamWilsn
force-pushed
the
sourcepos-tests
branch
from
12ebd94 to
38f2403
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if these are already covered elsewhere. I wrote one for my own knowledge, and kept going... A few are disabled because I believe the returned sourcepos are incorrect.
Apologies for stacking this on top of #497. Looking at just 38f2403 might be best.