Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Zig 0.11 #11

Merged
merged 4 commits into from
Aug 28, 2023
Merged

update to Zig 0.11 #11

merged 4 commits into from
Aug 28, 2023

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Aug 17, 2023

No description provided.

@glyh
Copy link

glyh commented Aug 23, 2023

addPackagePath is not present in zig 0.11:

/home/lyh/Documents/CS/compiler/yula/yula/build.zig:35:8: error: no field or member function named 'addPackagePath' in 'Build.Step.Compile'
    exe.addPackagePath("pcre", "vendor/libpcre.zig/src/main.zig");
    ~~~^~~~~~~~~~~~~~~
/home/lyh/.zvm/0.11.0/lib/std/Build/Step/Compile.zig:1:1: note: struct declared here
const builtin = @import("builtin");
^~~~~
referenced by:
    runBuild__anon_7159: /home/lyh/.zvm/0.11.0/lib/std/Build.zig:1638:27
    remaining reference traces hidden; use '-freference-trace' to see all reference traces

So readme should also be updated. But TBH there should be a way to integrate tightly with zon package manager instead.

@nektro
Copy link
Contributor Author

nektro commented Aug 25, 2023

I admit I only updated the library part of the code and not the build.zig

@glyh
Copy link

glyh commented Aug 25, 2023

I'm willing to help, so I fork your fork and commit on it?

Also, even if I fix it on my own end I got errors telling me zig can't find pcre package, which I didn't know how to fix.

@kivikakk
Copy link
Owner

I've pulled in the difference of @mattnite's #12 as 101d81c, and we have a flake.nix now too. Thank you all!

@kivikakk kivikakk merged commit 43df7fb into kivikakk:main Aug 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants