feature: move to telemetry events to report stats #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSBRK
reviewed
May 21, 2024
RSBRK
approved these changes
May 21, 2024
ssepml
force-pushed
the
telemetry
branch
2 times, most recently
from
b269213 to
83cbf4b
Compare
RSBRK
approved these changes
May 21, 2024
ssepml
changed the title
README.md
Outdated
|
|
||
| - `[krc_pb_client, request, stop]` emitted at the end of a request to riak | ||
| - Measurement: `#{duration => integer(), monotonic_time => integer()}` | ||
| - Metadata: `#{request => map(), response => ok | error, error => term()}` |
There was a problem hiding this comment.
Doesn't this one always include bucket as well? It looks like it reading the metadata helper in the code below.
There was a problem hiding this comment.
It does, it's inside the request map.
To extend on this a little bit, having the whole spec in there would make it a bit hard to read. The idea was to just have a high level idea of what's in the event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment, the library uses
stdlib2to report metrics which doesn't work as the system moved toprometheus.In this PR, the metrics are replaced with
telemetryevents that allow the main application to decide what to do with them: create metrics or logs.