Support Sentry users for general error macros #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chsukivra
approved these changes
Dec 16, 2019
maxno-kivra
force-pushed
the
mn-raven-user-from-extras
branch
8 times, most recently
from
1b2a914 to
c14fb47
Compare
The ?failed and ?exception macros get picked up by parse_message already
and allow attaching arbitray extra data to be sent to Sentry.
This makes it so that attaching `user` as extra data is sent as a proper
raven user, allowing Sentry to do smart things like count the number of
affected users and searching for all issues related to this user.
Sentry expects certain keys to work, from the docs:
id:
The unique ID of the user.
email:
The email address of the user.
ip_address:
The IP of the user.
username:
The username of the user.
All other keys are stored as extra information but not specifically
processed by Sentry.
To make this easier, if you don't provide a proplist/eon object, it will
default to using the `user` key as `id`.
maxno-kivra
force-pushed
the
mn-raven-user-from-extras
branch
from
c14fb47 to
a8a1ab2
Compare
|
I've tested this by hand in sandbox on beehive, and it looks pretty sweet if I say so myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ?failed and ?exception macros get picked up by parse_message already
and allow attaching arbitray extra data to be sent to Sentry.
This makes it so that attaching
useras extra data is sent as a properraven user, allowing Sentry to do smart things like count the number of
affected users and searching for all issues related to this user.