Allow setting custom p4a URL instead of fork #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayaurora
requested review from
AndreMiras and
opacam
and removed request for
AndreMiras
opacam
previously approved these changes
Mar 13, 2021
AndreMiras
previously approved these changes
Mar 13, 2021
Thank you! I'll give it a try. |
|
Great to hear, you could look into |
Co-authored-by: Pol Canelles <canellestudi@gmail.com>
syrykh
commented
Mar 14, 2021
| @@ -53,7 +53,7 @@ def init_buildozer(temp_dir, target, options=None): | |||
| spec = [] | |||
| for line in default_spec: | |||
| if line.strip(): | |||
| match = re.search(r"[#\s]?([a-z_\.]+)", line) | |||
| match = re.search(r"[#\s]?([0-9a-z_.]+)", line) | |||
There was a problem hiding this comment.
This change is needed to match "p4a", as it contains digit.
|
@AndreMiras, tests were added. Could you please check them? |
AndreMiras
approved these changes
Mar 14, 2021
|
@AndreMiras , @opacam , thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's not possible to set own p4a mirror (not a fork on GitHub) in buildozer.spec.
This possibility already exists for kivy_ios, but not for p4a.
This PR allows to setting custom URL for p4a in the spec, instead of simply specifying fork.
The URL is used at first place. If no URL is specified, then fallback to github fork happens:
Backward compatibility with old specs is preserved with no behavioral changes.