Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get JDK/JRE path pythonically #399

Merged
merged 6 commits into from
Feb 4, 2019
Merged

Get JDK/JRE path pythonically #399

merged 6 commits into from
Feb 4, 2019

Conversation

KeyWeeUsr
Copy link
Contributor

Remove readlink -f and sed, we have Python for replacing not sed + pipe and os.readlink() should work properly as a readlink -f alternative from Python's side.

Closes #100.

@KeyWeeUsr
Copy link
Contributor Author

Ok, this is silly, because I can't get which java(c) to work properly on Linux. I will resolve this later after more important stuff is done.

@tito tito added the wip label Feb 2, 2019
@KeyWeeUsr KeyWeeUsr merged commit afd9b42 into master Feb 4, 2019
@KeyWeeUsr KeyWeeUsr deleted the fix_readlink branch February 4, 2019 09:35
@KeyWeeUsr KeyWeeUsr added this to the 1.2.0 milestone Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
platform-linux
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@KeyWeeUsr @tito