Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Github Actions for tests and releases #444

Merged
merged 22 commits into from
Dec 1, 2019
Merged

Use Github Actions for tests and releases #444

merged 22 commits into from
Dec 1, 2019

Conversation

tshirtman
Copy link
Member

No description provided.

@AndreMiras
Copy link
Member

Nice initiative! What about relying on our Makefile more so it's more portable across CI and environments?
What I mean is for instance instead of having the tests prep and run "hardcoded" in the - name: test section, we could use what's already available in the tests target of our Makefile.
Also it's a different topic, but I'm wondering why we don't use tox here to test against multiple targets? Maybe tox is too old or cumbersome of pyjnius, but I'm wondering

@tshirtman tshirtman force-pushed the actions branch 6 times, most recently from 78f4694 to 53fc14c Compare October 12, 2019 19:30
@tshirtman tshirtman force-pushed the actions branch 13 times, most recently from 4c2a3ea to 92e8d57 Compare November 3, 2019 21:23
@tshirtman tshirtman force-pushed the actions branch 3 times, most recently from 70a7d81 to e9eb408 Compare November 30, 2019 15:47
@tshirtman tshirtman changed the title try github actions for tests Use Github Actions for tests and releases Nov 30, 2019
tito
tito previously approved these changes Nov 30, 2019
View reviewed changes
@tshirtman tshirtman merged commit 49e2e5e into master Dec 1, 2019
@tshirtman tshirtman deleted the actions branch December 1, 2019 01:51
@tshirtman tshirtman mentioned this pull request Dec 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tito tito tito left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tshirtman @AndreMiras @tito