Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zworkb services #1725

Merged
merged 5 commits into from
Jun 6, 2019
Merged

Zworkb services #1725

merged 5 commits into from
Jun 6, 2019

Conversation

zworkb
Copy link
Contributor

@zworkb zworkb commented Feb 24, 2019

minor changes for service_only bootstrap:

  • service_only was recjeted by build.py (fixed that thanks to @AndreMiras 's hint)
  • removed dep on crystax in setup.py in testapps/setup_testapp_service.py
  • create own notification channel in PythonService.java (needed for android 8+)
  • catch the case that kivy is not in the requirements and thus some args are missing

service_only bootstrap now works with android (7 and 8 tested)

@AndreMiras
Copy link
Member

Looks very good overall, thanks for making p4a a better place! We left a couple of comments if you could review/address.
Cheers!

@AndreMiras
Copy link
Member

Hey @zworkb we're almost there! Do you mind taking a final look at the couple of comments not yet addressed so we can test and merge?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor thing for code readability in android/__init__.py, but I think is_service_only or similar should be used rather than misusing is_webview (see also my comment)

pythonforandroid/recipes/android/__init__.py Outdated Show resolved Hide resolved
@AndreMiras
Copy link
Member

Thanks again for all that hard work. Would you mind rebasing/squashing your changes. I cannot really review since the diff is very confusing and hard to read. There're changes from other PR that ended up in here somehow.
image

@zworkb zworkb force-pushed the zworkb-services branch from f9e2c88 to 65089bf Compare May 30, 2019 13:54
@@ -17,7 +17,7 @@
* {@inheritDoc}
*/
@Override
public int getStartType() {
public int startType() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've seen this change breaking things in the past. I haven't tried on device (Android 7) yet, but are we sure-ish about it?

@AndreMiras
Copy link
Member

Thanks for rebasing/squashing. It looks pretty good overall! 👏
I still want to test it on Android 7 to see if we don't have regression. My schedule is pretty awful lately, but I'll try asap.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified that Android 7 is still happy.
Thanks for the PR

@AndreMiras
Copy link
Member

@Jonast I think your comment was addressed, could you review/approve if things are OK to you too?

@ghost
Copy link

ghost commented Jun 6, 2019

Looks good 👍


Unrelated/not merge relevant: surprise mega confusion wait what, what's that "sdl2python3" in the code? is that some super old relic? not something that is to be fixed by this pull request of course since it's in the code part left alone, but I've never seen that and I rearranged all the bootstraps so that's weird 😄 edit: and "sdl2_gradle" is from where the "normal" sdl2 bootstrap was still ant I assume, that has to refer to something removed decades ago as well 😂

@AndreMiras AndreMiras merged commit 1d375fb into kivy:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants