-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zworkb services #1725
Zworkb services #1725
Conversation
pythonforandroid/bootstraps/common/build/src/main/java/org/kivy/android/PythonService.java
Outdated
Show resolved
Hide resolved
pythonforandroid/bootstraps/common/build/src/main/java/org/kivy/android/PythonService.java
Outdated
Show resolved
Hide resolved
pythonforandroid/bootstraps/common/build/src/main/java/org/kivy/android/PythonService.java
Outdated
Show resolved
Hide resolved
Looks very good overall, thanks for making p4a a better place! We left a couple of comments if you could review/address. |
pythonforandroid/bootstraps/common/build/src/main/java/org/kivy/android/PythonService.java
Outdated
Show resolved
Hide resolved
Hey @zworkb we're almost there! Do you mind taking a final look at the couple of comments not yet addressed so we can test and merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a minor thing for code readability in android/__init__.py
, but I think is_service_only
or similar should be used rather than misusing is_webview
(see also my comment)
pythonforandroid/bootstraps/common/build/src/main/java/org/kivy/android/PythonService.java
Outdated
Show resolved
Hide resolved
pythonforandroid/bootstraps/common/build/src/main/java/org/kivy/android/PythonService.java
Outdated
Show resolved
Hide resolved
pythonforandroid/bootstraps/common/build/src/main/java/org/kivy/android/PythonService.java
Show resolved
Hide resolved
pythonforandroid/bootstraps/common/build/src/main/java/org/kivy/android/PythonService.java
Outdated
Show resolved
Hide resolved
@@ -17,7 +17,7 @@ | |||
* {@inheritDoc} | |||
*/ | |||
@Override | |||
public int getStartType() { | |||
public int startType() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've seen this change breaking things in the past. I haven't tried on device (Android 7) yet, but are we sure-ish about it?
Thanks for rebasing/squashing. It looks pretty good overall! 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified that Android 7 is still happy.
Thanks for the PR
@Jonast I think your comment was addressed, could you review/approve if things are OK to you too? |
Looks good 👍 Unrelated/not merge relevant: surprise mega confusion wait what, what's that |
minor changes for service_only bootstrap:
service_only bootstrap now works with android (7 and 8 tested)