set urllib user-agent #2437
Merged
set urllib user-agent #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
reviewed
Mar 5, 2021
| # jqueryui.com returns a 403 w/ the default user agent | ||
| url_opener = urllib.request.build_opener() | ||
| url_opener.addheaders = [('User-agent', 'Mozilla/5.0')] | ||
| urllib.request.install_opener(url_opener) |
There was a problem hiding this comment.
Doesn't this change it at global level? Can't we use some kind of context manager or something so it's rolled back after the recipe download is done?
There was a problem hiding this comment.
It does. But since this is the only use of urllib in p4a and it seems unlikely that a different user agent would matter to any other code anyway, it seemed like the easiest solution.
There was a problem hiding this comment.
I changed the code. Is this better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2418