Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistenly assign Broadlink.devices keys with macAddress.toString('hex') #22

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Consistenly assign Broadlink.devices keys with macAddress.toString('hex') #22

merged 5 commits into from
Jul 5, 2024

Commits on Jul 21, 2022

  1. v0.9.18 (kiwi-cam#20) 

    * Adds support for 0x520b and 0x520c Devices
    @kiwi-cam
    kiwi-cam authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    23272b0 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Adding support for 520d devices

    @kiwi-cam
    kiwi-cam committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    a8f16f1 View commit details
    Browse the repository at this point in the history

  2. Adding support for 520d devices

    @kiwi-cam
    kiwi-cam committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2ecff93 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Consistenly assign the key on Broadlink.devices with macAddress.toStr… 

    …ing('hex')

Otherwise, Broadlink.addDevice check always fail to match any existing devices.

Moreover, String(macAddress) can return clashing string values, even if the buffer values are different, so it is not a safe function to have unique keys from the buffer value.
    Octavi Font committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    e162a2e View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Merge branch 'beta' into fix-broadlink-devices-key-logic

    @kiwi-cam
    kiwi-cam authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    6af5fe5 View commit details
    Browse the repository at this point in the history