Replaced switch's use of refreshCharacteristicUI to update the UI (#725)

kiwi-cam · Sep 25, 2024 · cd5d1f2 · cd5d1f2
1 parent 540756b
commit cd5d1f2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 ### Fixed
  - refreshCharacteristic and value() were not updating the UI. Rebuilt to use updateValue method. (#733)
+ - Replaced switch's use of refreshCharacteristicUI to update the UI (#725)
 ### Added
  - updated package to show Homebridge 2.0 support (#730)
 

diff --git a/accessories/switch.js b/accessories/switch.js
@@ -63,7 +63,8 @@ class SwitchAccessory extends BroadlinkRMAccessory {
 
     if (this.serviceManager.getCharacteristic(Characteristic.On) === undefined) {
       this.state.switchState = false;
-      this.serviceManager.refreshCharacteristicUI(Characteristic.On);
+      //this.serviceManager.refreshCharacteristicUI(Characteristic.On);
+      this.serviceManager.updateCharacteristic(Characteristic.On, this.state.switchState);
     }
   }
 
@@ -100,7 +101,8 @@ class SwitchAccessory extends BroadlinkRMAccessory {
 
     if (config.pingIPAddressStateOnly) {
       state.switchState = active ? true : false;
-      serviceManager.refreshCharacteristicUI(Characteristic.On);
+      //serviceManager.refreshCharacteristicUI(Characteristic.On);
+      serviceManager.updateCharacteristic(Characteristic.On,state.switchState);
 
       return;
     }
@@ -118,7 +120,8 @@ class SwitchAccessory extends BroadlinkRMAccessory {
 
     if (config.stateless === true) { 
       state.switchState = false;
-      serviceManager.refreshCharacteristicUI(Characteristic.On);
+      // serviceManager.refreshCharacteristicUI(Characteristic.On);
+      serviceManager.updateCharacteristic(Characteristic.On,state.switchState);
     } else {
       this.checkAutoOnOff();
     }