Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.json hosts section not working with MAC address #266

Closed
freedivebird opened this issue Mar 13, 2021 · 4 comments
Closed

config.json hosts section not working with MAC address #266

freedivebird opened this issue Mar 13, 2021 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@freedivebird
Copy link

freedivebird commented Mar 13, 2021

  1. hosts mac address not working per documentation,
  2. Inconsistent handling of mac addresses,

To Reproduce
In config.json hosts section, if you try to put mac addresses as per the documentation, like

                   "hosts": [
                {
                    "address": "192.168.0.200",
                    "mac": "aa:bb:cc:dd:ee:ff",
                    "isRFSupported": true,
                    "isRM4": true
                },
                {
                    "address": "192.168.0.199",
                    "mac": "ff:ee:dd:cc:bb:aa",
                    "isRFSupported": true,
                    "isRM4": true
                }
            ],

Open the log file and you will see that the plugin will try to insert further colons into the mac address -

[INFO] Discovered Manual RM Pro Device (2223) at 192.168.0.200 
(aa::b:b::cc::d:d::ee::f:f)

Screenshot 2021-03-13 at 1 44 14 AM

So obviously the plugin is expecting the mac addresses in the config.json file to be without colons, but if you try to put a host value in the accessories without the colons, homebridge will issue an error warning say the host cannot be found when trying to send a hex

  • OS: Synology
  • Node.js V14.16.0
  • npm 6.14.11
  • homebridge-broadlink-rm-pro v4.4.1
@freedivebird freedivebird added the bug Something isn't working label Mar 13, 2021
@masterfordev
Copy link

You can use the IP or the MAC, so, if you are using a static IP, set up with the static ip, and dont set the MAC, and when you send the IR command, use host: ip. That's how I use it.

@freedivebird
Copy link
Author

Thank you! Actually that's what I am using now - but just found out the bug with regards to the mac address while playing with the configurations earlier :)

@masterfordev
Copy link

Ok. Thanks for the report. Hope @kiwi-cam can fix it.

@freedivebird
Copy link
Author

freedivebird commented Mar 13, 2021

And @kiwi-cam while you are at it, I spotted another error in the documentation. A missing comma behind

"isRFSupported": true

Screenshot 2021-03-14 at 12 46 41 AM

Many thanks for keeping it up to date for the RM4 Pro too! Really appreciate your work!

@kiwi-cam kiwi-cam changed the title config.json hosts section not working as intended/documented config.json hosts section not working with MAC address Mar 24, 2021
@kiwi-cam kiwi-cam self-assigned this Mar 24, 2021
kiwi-cam added a commit that referenced this issue Mar 25, 2021
@kiwi-cam kiwi-cam added this to the In BETA milestone Mar 25, 2021
@kiwi-cam kiwi-cam mentioned this issue Apr 7, 2021
kiwi-cam added a commit that referenced this issue Apr 7, 2021
 - [Improvement] Set node-persist to ignore parse errors to stop crashing the plugin on read errors
 - [Improvement] Sets "undefined" characteristics to either 0 or minValue to prevent future Homebridge errors
 - [Improvement] Adds offDryMode configuration option to the airconditioner accessory. Thanks @pixeleyesltd
 - [Improvement] Adds stateless configuration switch option to have a switch "forget" its state
 - [Improvement] Adds Eve History service support. This can be disabled by adding `"noHistory":true` to your config
 - [Improvement] Moves onTemperature and onHumidity logging to Debug only, reducing noice in the logs from all updates
 - [Bug] Fixes mac address formatting error when using manual hosts devices #266
 - [Bug] Fixes Accessory mac address formatting to support all formats the hosts section does - and improve matching to devices.
 - [Bug] Stopped MQTT updates from defaulting to 0 when the topic isn't found. This does create messages that the plugin is slowing homebridge until MQTT updates are recieved.

Co-authored-by: newt10 <42853152+newt10@users.noreply.github.com>
Co-authored-by: Maximilian Krause <hello@max-krause.com>
@kiwi-cam kiwi-cam closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants