Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/eslint support #347

Merged
merged 4 commits into from
Jun 22, 2021
Merged

Feature/eslint support #347

merged 4 commits into from
Jun 22, 2021

Conversation

aceslick911
Copy link

Hi, I noticed this plugin frequently throws errors in the console and noticed that after I added some basic linting, a lot of these issues have been resolved!

Please consider my PR as I'm sick of all the crashing!!

How to use:
npm run lint will show all warnings (also provided in VSCode)
npm run lint-fix will fix all auto-fixable warnings (such as spaces, semicolons etc)

I've disabled a lot of the es-lint rules to prevent this PR from being HUGE and resolving issues that could have actual execution problems (such as using === to == may return different results)

kiwi-cam
kiwi-cam approved these changes Jun 22, 2021
View reviewed changes
Copy link
Owner

@kiwi-cam kiwi-cam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious what crashes you're seeing??

All these changes appear to be just fixing some inconsistent (and sometimes lazy) coding. I don't see any changes that would resolve crashes or change the functionality.

@kiwi-cam kiwi-cam merged commit d6f6445 into kiwi-cam:beta Jun 22, 2021
@aceslick911
Copy link
Author

I'm curious what crashes you're seeing??

All these changes appear to be just fixing some inconsistent (and sometimes lazy) coding. I don't see any changes that would resolve crashes or change the functionality.

9a78ce4?diff=unified&w=1

Have a look at that commit with white space turned off. Lots of missing declarations and not using “this” when needed.

kiwi-cam added a commit that referenced this pull request Aug 2, 2021
@kiwi-cam
v4.4.6 - Squashed commit of the following:
deb5f01 
commit 4b209ca
Author: Kiwi Cam <32912464+kiwi-cam@users.noreply.github.com>
Date:   Mon Aug 2 10:14:29 2021 +1200

    v4.4.6-beta.4

commit 0a29ea8
Author: Kiwi Cam <32912464+kiwi-cam@users.noreply.github.com>
Date:   Mon Aug 2 10:00:06 2021 +1200

    Updated broadlinkjs-rm version

commit 0563c25
Author: Dave Nicolson <david.nicolson@gmail.com>
Date:   Sun Aug 1 23:58:50 2021 +0200

    Fix version checking (#366)

    * Fix GitHub username
    * Fix parameter order
    * Fix variable name
    * Update repo name and owner

    Co-authored-by: Cameron <32912464+kiwi-cam@users.noreply.github.com>

commit d29340d
Author: Kiwi Cam <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jul 28 13:56:11 2021 +1200

    Release 4.4.6-beta.3

commit ace9245
Author: Kiwi Cam <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jul 28 13:51:13 2021 +1200

    Adds 6508 device support

commit 2be2ea3
Merge: e42b48b 04b57dd
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Tue Jul 27 13:18:30 2021 +1200

    Merge branch 'beta' of https://github.com/kiwi-cam/homebridge-broadlink-rm into beta

commit 04b57dd
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Tue Jul 27 13:14:25 2021 +1200

    v4.4.6-beta.2

    v4.4.6-beta.2

commit e42b48b
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Tue Jul 27 13:17:13 2021 +1200

    v4.4.6-beta.2

commit 68014e7
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Tue Jul 27 13:14:25 2021 +1200

    v4.4.6-beta.2

commit 7587618
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Tue Jul 27 11:30:29 2021 +1200

    Removed cached temperature feature

commit bf49203
Author: kiwi-cam <32912464+kiwi-cam@users.noreply.github.com>
Date:   Sun Jul 25 08:03:21 2021 +1200

    Update package-lock.json

commit d1aed4f
Author: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Date:   Sun Jul 25 07:55:53 2021 +1200

    v4.4.6-beta.1

commit 1d73598
Author: Nick Drew <nick.s.drew@gmail.com>
Date:   Sun Jul 25 05:53:50 2021 +1000

    Fix for tv registration on hoobs 4 (#363)

    * Pass plugin name to homebridge accessory registration - Fixes #360

    Co-authored-by: Cameron <32912464+kiwi-cam@users.noreply.github.com>
    Co-authored-by: Nick Drew <nick.drew@staff.smartline.com.au>

commit 534033f
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Fri Jul 23 10:16:25 2021 +1200

    HOOBs note

commit 5a6f850
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Fri Jul 23 10:10:42 2021 +1200

    Fixed TV platform name

commit 4da80a8
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Fri Jul 23 09:15:03 2021 +1200

    Fixed mqtt onTemperature handling

commit 637ce6e
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Thu Jul 22 10:07:45 2021 +1200

    Updated useCachedTemperature to default to true when using mqtt

commit ea9886d
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Thu Jul 22 09:06:43 2021 +1200

    Added useCachedTemperature option to improve response time

commit 36bb491
Author: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Date:   Mon Jul 19 08:29:30 2021 +1200

    Added eslint change note

commit fbd1d12
Author: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Date:   Mon Jul 5 07:46:21 2021 +1200

    Revert "Added allowResendOnOff"

    This reverts commit 17d59af.

commit 7b333ac
Author: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Date:   Mon Jul 5 07:46:16 2021 +1200

    Revert "Added logLevel to allowResendOnOff debug logs"

    This reverts commit 71b955a.

commit 71b955a
Author: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Date:   Sun Jul 4 08:16:03 2021 +1200

    Added logLevel to allowResendOnOff debug logs

commit 17d59af
Author: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Date:   Sun Jul 4 08:13:56 2021 +1200

    Added allowResendOnOff

commit fead1e4
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 23 10:53:11 2021 +1200

    Updated package-lock

commit d6f6445
Author: Aceslick911 <angeloperera@gmail.com>
Date:   Wed Jun 23 08:45:12 2021 +1000

    Feature/eslint support (#347)

    * Added Eslint support
    * Fixed legitimate issues found with linting
    * Lint optimisation for all warn issues

    Co-authored-by: Angelo Perera <angelo.perera@nintex.com>
    Co-authored-by: Cameron <32912464+kiwi-cam@users.noreply.github.com>

commit eb3dad0
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 23 10:30:54 2021 +1200

    New BETA

commit 0f6bc58
Merge: 022beeb 883f234
Author: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 23 10:18:13 2021 +1200

    Merge branch 'master' into beta

commit 022beeb
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Tue Jun 22 10:06:58 2021 +1200

    Typo

commit 1ea1ec6
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Tue Jun 22 10:03:21 2021 +1200

    Beta 4.4.5-beta.3

commit 78b84df
Author: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Date:   Tue Jun 22 09:24:56 2021 +1200

    Updated MQTT version

commit cbdec6b
Author: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Date:   Sat Jun 19 07:08:19 2021 +1200

    v4.4.5-beta.2

commit f64db2b
Author: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Date:   Sat Jun 19 06:59:21 2021 +1200

    Fixes MQTT logLevel undefined errors #343

commit 3f19e3a
Author: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Date:   Sat Jun 19 06:53:33 2021 +1200

    Sets noHumidity for sources without it #341

commit f18475f
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Thu Jun 17 07:54:24 2021 +1200

    New BETA

commit dcfbfc4
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Thu Jun 17 07:46:58 2021 +1200

    new BETA

commit f47bcf9
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Thu Jun 17 07:44:40 2021 +1200

    Fix for logLevel is not defined #341

commit 0dcdd7d
Author: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 16 21:10:52 2021 +1200

    Heater cooler updates status based on mode #229

commit ebeeeac
Author: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 16 20:28:56 2021 +1200

    Added note about fixing #328

commit 57723fb
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 16 11:02:07 2021 +1200

    New BETA package-lock.json

commit 3b0e5d3
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 16 10:45:12 2021 +1200

    Added change notes

commit 637d3fc
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 16 10:40:24 2021 +1200

    allowResent default to use preventResendHex #334

commit c09550a
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 16 10:32:18 2021 +1200

    Added error catch for #337

commit d398d1c
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 16 10:27:37 2021 +1200

    Updated CurrentTemperature limits to spec #338

commit fe52495
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 16 10:24:56 2021 +1200

    Fix for name not defined #339

commit 789022b
Merge: 2c4eac4 af94de8
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 9 16:09:37 2021 +1200

    Merge branch 'beta' of https://github.com/kiwi-cam/homebridge-broadlink-rm into beta

commit 2c4eac4
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 9 16:09:16 2021 +1200

    Fix for switch without break

commit af94de8
Author: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 9 15:19:46 2021 +1200

    Formatting

commit f5c3070
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 9 15:18:58 2021 +1200

    Adds installation notes to README closes #329

commit ed98461
Author: Cameron McConnochie <32912464+kiwi-cam@users.noreply.github.com>
Date:   Wed Jun 9 15:14:02 2021 +1200

    New BETA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiwi-cam kiwi-cam kiwi-cam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aceslick911 @kiwi-cam