Serialize command sequence to enable last pause command. #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Security updates * Turn off air-conditioner accessory automatically after onDuration seconds. (kiwi-cam#446) Co-authored-by: banboobee <98196664+banboobee@users.noreply.github.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Dear Kiwi-cam, Note that PR #528 and PR #520 are mutually exclusive, and either one of them should be applied. PR #520 queues sendData() to resolve the collision between accessories sharing same broadlink device. PR #528 queues performSend() to resolve the collision within a accessory also. performSend() calls sendData() internally, applying both duplicates the queueing operation, and unexpected behavior may arise, I geuss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serializes the command sequence of Advanced HEX Structure to deal with issue #478. In addition to serializing primitive IR/RF commands of PR #520, this PR also serializes pause/interval commands. Adding pause command to last step of the sequence, next command has to wait for pausing time before its evaluation. Thus, any "minimum time between commands" can be implemented using Advanced HEX Structure. I wish the issue author validates this PR and inform the results.
This PR also manages Problem 2 of issue #471. Although similar issues are reported sometime, it is not a bug but an intended behavior. To avoid simultaneous temporal command operations, succeeding command cancels out operating command. Hence, power command cancels out input selection command for TV in a scene, and sent only once. Since this PR serializes input and power commands, both commands are expected to be completed successfully.