Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set HAP properties for fan speed handling #583

Closed
wants to merge 12 commits into from
4 changes: 2 additions & 2 deletions .github/stale.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Number of days of inactivity before an issue becomes stale
daysUntilStale: 60
daysUntilStale: 90
# Number of days of inactivity before a stale issue is closed
daysUntilClose: 7
daysUntilClose: 14
# Issues with these labels will never be considered stale
exemptLabels:
- pinned
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
## [4.4.11] - 2022-06-08
### Added
- MQTT support for zigbee2mqtt (Thanks @mikicof) #467
### Fixed
Expand Down
7 changes: 7 additions & 0 deletions accessories/fan.js
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,13 @@ class FanAccessory extends SwitchAccessory {
}
});

// Add HAP properties for improved accessory representation in Homekit
this.getCharacteristic(Characteristic.RotationSpeed).setProps({
minStep: config.stepSize,
minValue: 0,
maxValue: 100
});

if (config.showRotationDirection) {
this.serviceManager.addToggleCharacteristic({
name: 'rotationDirection',
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "homebridge-broadlink-rm-pro",
"displayName": "Homebridge Broadlink RM Pro",
"version": "4.4.11-beta.4",
"version": "4.4.11",
"description": "Broadlink RM plugin (including the mini and pro) for homebridge with AC Pro and TV features",
"license": "ISC",
"scripts": {
Expand Down Expand Up @@ -29,7 +29,7 @@
"url": "git@github.com:kiwi-cam/homebridge-broadlink-rm.git"
},
"dependencies": {
"kiwicam-broadlinkjs-rm": "^0.9.17-beta.2",
"kiwicam-broadlinkjs-rm": "^0.9.17",
"chai": "^4.3.6",
"find-key": "^2.1.3",
"github-version-checker": "^2.3.0",
Expand Down