Ignore fanSpeed key when looking for fan speeds #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiwi-cam
added a commit
that referenced
this pull request
Jul 6, 2024
* Serialize the simultaneous commands. * Fix fan switchState when resetting to defaults (#592) * Fix switchState when resetting to defaults --------- Co-authored-by: Cameron <32912464+kiwi-cam@users.noreply.github.com> Co-authored-by: banboobee <98196664+banboobee@users.noreply.github.com> * Ignore fanSpeed key when looking for fan speeds (#593) * Ignore fanSpeed key when looking for fan speeds --------- Co-authored-by: Cameron <32912464+kiwi-cam@users.noreply.github.com> Co-authored-by: banboobee <98196664+banboobee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an empty string being added to the
foundSpeedsarray, thefanSpeedkey is available in addition tofanSpeedXkeys since #286.The result of the following is still desired:
'fanSpeed20'.split('fanSpeed')[1]But not this:
'fanSpeed'.split('fanSpeed')[1]The logic is then simplified in fb298a6.
The
fanSpeedkey is also missing from the documentation.