4.4.18 release

CHANGELOG.md

@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [4.4.18 - 2024-08-08]
+### Added
+ - Added ping state change logging for troubleshooting
+### Changed
+ - Removed use of Characteristic.getValue() in preparation of homebridge 2.0 (#722)
+ - The removal of getValue() has stopped the regular getCurrentTemperature and getCurrentHumidity calls. Changed the regualar updates to make these calls instead of just using refreshCharacteristic. (#722)
+
 ## [4.4.17 - 2024-07-17]
 ### Added
  - Adds support for RM3 Mini 0x27d0 (#691)

accessories/aircon.js

@@ -243,7 +243,7 @@
     }
 
     let temperature = state.targetTemperature;
     let mode = HeatingCoolingConfigKeys[state.targetHeatingCoolingState];
 
     if (state.currentHeatingCoolingState !== state.targetHeatingCoolingState){
       // Selecting a heating/cooling state allows a default temperature to be used for the given state.
@@ -284,7 +284,7 @@
   async checkAutoOff () {
     await catchDelayCancelError(async () => {
       const {config, name, data, log} = this;
       let {enableAutoOff, onDuration, enableAutoOn, offDuration} = config;
       onDuration = onDuration|| 60;
       offDuration = offDuration|| 60;
 
@@ -344,7 +344,7 @@
 
     let finalTemperature = temperature;
     if (mode === 'off') {
       let hexData = data.off;
       return { finalTemperature, hexData };
     } 
     let hexData = data[`${mode}${temperature}`];
@@ -423,7 +423,7 @@
     device.checkTemperature();
 
     this.updateTemperatureUI();
-    if (!config.isUnitTest) {setInterval(this.updateTemperatureUI.bind(this), config.temperatureUpdateFrequency * 1000)}
+    if (!config.isUnitTest) {setInterval(()=>{this.getCurrentTemperature(this.updateTemperatureUI.bind(this))}, config.temperatureUpdateFrequency * 1000)}
   }
 
   onTemperature (temperature,humidity) {
@@ -547,7 +547,7 @@
       } else {
         lines.forEach((line) => {
           if(-1 < line.indexOf(':')){
             let value = line.split(':');
             if(value[0] == 'temperature') {temperature = parseFloat(value[1]);}
             if(value[0] == 'humidity' && !noHumidity) {humidity = parseFloat(value[1]);}
             if(value[0] == 'battery' && batteryAlerts) {battery = parseFloat(value[1]);}
@@ -643,7 +643,7 @@
 
   async checkTemperatureForAutoOnOff (temperature) {
     const { config, host, log, logLevel, name, serviceManager, state } = this;
     let { autoHeatTemperature, autoCoolTemperature, minimumAutoOnOffDuration } = config;
 
     if (this.shouldIgnoreAutoOnOff) {
       if (logLevel <=2) {log(`${name} checkTemperatureForAutoOn (ignore within ${minimumAutoOnOffDuration}s of previous auto-on/off due to "minimumAutoOnOffDuration")`);}

accessories/humidifier-dehumidifier.js

@@ -202,7 +202,7 @@ class HumidifierDehumidifierAccessory extends FanAccessory {
     device.checkHumidity();
 
     this.updateHumidityUI();
-    if (!config.isUnitTest && !config.noHumidity) {setInterval(this.updateHumidityUI.bind(this), config.humidityUpdateFrequency * 1000)}
+    if (!config.isUnitTest && !config.noHumidity) {setInterval(()=>{this.getCurrentHumidity(this.updateHumidityUI.bind(this))}, config.humidityUpdateFrequency * 1000)}
   }
 
   onHumidity (temperature,humidity) {

accessories/switch.js

@@ -90,12 +90,14 @@ class SwitchAccessory extends BroadlinkRMAccessory {
   }
 
   pingCallback (active) {
-    const { config, state, serviceManager } = this;
+    const { config, state, serviceManager, name, log, logLevel } = this;
 
     if (this.stateChangeInProgress){ 
       return; 
     }
-
+
+    if (state.switchState !== active && logLevel <=2){log(`\x1b[35m[INFO]\x1b[0m ${name} ping detected state change, now ${active}`);}
+
     if (config.pingIPAddressStateOnly) {
       state.switchState = active ? true : false;
       serviceManager.refreshCharacteristicUI(Characteristic.On);

helpers/serviceManager.js

@@ -24,7 +24,7 @@ class ServiceManager {
   }
 
   refreshCharacteristicUI (characteristic) {
-    this.getCharacteristic(characteristic).getValue();
+    this.getCharacteristic(characteristic).value;
   }
 
   // Convenience
@@ -76,4 +76,4 @@ class ServiceManager {
   }
 }
 
-module.exports = ServiceManager
+module.exports = ServiceManager

package.json

@@ -1,7 +1,7 @@
 {
   "name": "homebridge-broadlink-rm-pro",
   "displayName": "Homebridge Broadlink RM Pro",
-  "version": "4.4.17",
+  "version": "4.4.18",
   "description": "Broadlink RM plugin (including the mini and pro) for homebridge with AC Pro and TV features",
   "license": "ISC",
   "scripts": {
@@ -32,10 +32,10 @@
     "await-semaphore": "^0.1.3",
     "kiwicam-broadlinkjs-rm": "^0.9.22",
     "chai": "^4.3.7",
-    "fakegato-history": "^0.6.4",
+    "fakegato-history": "^0.6.5",
     "find-key": "^2.1.3",
     "github-version-checker": "^2.3.0",
-    "mqtt": "^5.8.0",
+    "mqtt": "^5.8.1",
     "node-persist": ">=2.1.0 <3.0.0",
     "semver": "^7.5.4",
     "node-arp": "^1.0.6",