Skip to content
This repository has been archived by the owner on Sep 29, 2020. It is now read-only.

add Support for data tables #14 #31

Merged
merged 6 commits into from
Apr 3, 2019
Merged

add Support for data tables #14 #31

merged 6 commits into from
Apr 3, 2019

Conversation

jvdieten
Copy link
Contributor

  • Support cucumber data tables
  • Added examples
  • Updated README

Lukas-Kullmann
Lukas-Kullmann suggested changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@Lukas-Kullmann Lukas-Kullmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the typescript definitions to include the data tables.

examples/datatable.feature Show resolved Hide resolved
src/compiler.js Outdated Show resolved Hide resolved
@Lukas-Kullmann Lukas-Kullmann added the enhancement New feature or request label Mar 28, 2019
@Lukas-Kullmann
Copy link
Contributor

Thanks for you contribution, @jvdieten !
I think it's a great feature and with some small changes, we can release it soon. :)

This fixes #14.

Lukas-Kullmann
Lukas-Kullmann suggested changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@Lukas-Kullmann Lukas-Kullmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the data tables to the typescript definition files.

src/compiler.js Outdated Show resolved Hide resolved
@Lukas-Kullmann Lukas-Kullmann merged commit 9b2c041 into kiwigrid:master Apr 3, 2019
@Lukas-Kullmann
Copy link
Contributor

Thanks for your contribution, @jvdieten!

I published v2.2.0 with your changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Lukas-Kullmann Lukas-Kullmann Lukas-Kullmann approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvdieten @Lukas-Kullmann