Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bootstrap-switch from 3.3.4 to 3.4.0 #1450

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

snyk-bot
Copy link
Contributor

Snyk has created this PR to upgrade bootstrap-switch from 3.3.4 to 3.4.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
  • The recommended version is 2 versions ahead of your current version.
  • The recommended version was released a year ago, on 2019-04-13.
Release notes
Package name: bootstrap-switch
  • 3.4.0 - 2019-04-13
  • 3.3.5 - 2019-04-13
  • 3.3.4 - 2017-02-25
    • Fix Object.assign not working for IE <= 11 #616
from bootstrap-switch GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.327% when pulling 36fbd68 on snyk-upgrade-a8947984442f9b74f44fc71268738ce9 into 6cd7188 on master.

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #1450 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1450   +/-   ##
=======================================
  Coverage   74.97%   74.97%           
=======================================
  Files         123      123           
  Lines        4644     4644           
  Branches      569      569           
=======================================
  Hits         3482     3482           
  Misses        966      966           
  Partials      196      196           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd7188...36fbd68. Read the comment docs.

@atodorov atodorov changed the title [Snyk] Upgrade bootstrap-switch from 3.3.4 to 3.4.0 [do not merge] Upgrade bootstrap-switch from 3.3.4 to 3.4.0 Mar 24, 2020
@atodorov
Copy link
Member

v3.4 pulls bootstrap v4 and I don't think this is compatible with Patternfly 3.

@atodorov atodorov added the DO NOT MERGE Do not merge until this label is removed label Mar 29, 2020
@asankov
Copy link
Member

asankov commented Apr 13, 2020

unfortunately, this project is nearly dead.

the last commit is from a year ago, PRs and issues are hanging. for instance - Bttstrp/bootstrap-switch#700 this PR fixes the issue that does not allow us to migrate to 3.4.0

@atodorov atodorov force-pushed the snyk-upgrade-a8947984442f9b74f44fc71268738ce9 branch from 36fbd68 to 572d1f0 Compare November 10, 2022 11:14
@atodorov atodorov changed the title [do not merge] Upgrade bootstrap-switch from 3.3.4 to 3.4.0 Upgrade bootstrap-switch from 3.3.4 to 3.4.0 Nov 10, 2022
@atodorov atodorov removed the DO NOT MERGE Do not merge until this label is removed label Nov 10, 2022
@atodorov
Copy link
Member

v3.4.0 will be installed with missing peer dependency bootstrap@^4.3.1 but that doesn't seem to affect anything. We're onnly using the CSS file from this package to make checkboxes look as toggle buttons.

@atodorov atodorov merged commit e54ce70 into master Nov 10, 2022
@atodorov atodorov deleted the snyk-upgrade-a8947984442f9b74f44fc71268738ce9 branch November 10, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants