-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bootstrap-switch from 3.3.4 to 3.4.0 #1450
Upgrade bootstrap-switch from 3.3.4 to 3.4.0 #1450
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1450 +/- ##
=======================================
Coverage 74.97% 74.97%
=======================================
Files 123 123
Lines 4644 4644
Branches 569 569
=======================================
Hits 3482 3482
Misses 966 966
Partials 196 196 Continue to review full report at Codecov.
|
v3.4 pulls bootstrap v4 and I don't think this is compatible with Patternfly 3. |
unfortunately, this project is nearly dead. the last commit is from a year ago, PRs and issues are hanging. for instance - Bttstrp/bootstrap-switch#700 this PR fixes the issue that does not allow us to migrate to 3.4.0 |
Snyk has created this PR to upgrade bootstrap-switch from 3.3.4 to 3.4.0. See this package in NPM: https://www.npmjs.com/package/bootstrap-switch See this project in Snyk: https://app.snyk.io/org/atodorov/project/eea9dc80-678d-420b-95d3-245a0d63fd63?utm_source=github&utm_medium=upgrade-pr
36fbd68
to
572d1f0
Compare
v3.4.0 will be installed with missing peer dependency bootstrap@^4.3.1 but that doesn't seem to affect anything. We're onnly using the CSS file from this package to make checkboxes look as toggle buttons. |
Snyk has created this PR to upgrade bootstrap-switch from 3.3.4 to 3.4.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.Release notes
Package name: bootstrap-switch
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs