753 donate with apple pay button for iOS to support Kiwix

[BPerlakiH]

Fixes: #753

Should be tested with real payments to see if it works end to end.

[rgaudin]

This is a UI PR ; please include a screencast or screenshots.

[BPerlakiH]

apple_pay_iphone.mov

apple_pay_ipad.mov

apple_pay_macos.mov

[kelson42]

@BPerlakiH Nice, but CI is red!

[BPerlakiH]

From what I suspect, this might require more integration into Stripe, to get the available payment options from there, and possibly make the payments appear on Stripe dashboard, but let's try it without it first.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 7.60000% with 462 lines in your changes missing coverage. Please review.

Project coverage is 36.01%. Comparing base (30b3e9b) to head (9692781).

Files with missing lines	Patch %	Lines
Model/Payment.swift	0.00%	92 Missing ⚠️
Views/Settings/Settings.swift	0.00%	67 Missing ⚠️
Views/Payment/ListOfAmounts.swift	0.00%	54 Missing ⚠️
Model/StripeKiwix.swift	0.00%	53 Missing ⚠️
Views/Payment/CustomAmount.swift	0.00%	48 Missing ⚠️
Views/Payment/PaymentForm.swift	6.25%	45 Missing ⚠️
Views/Payment/PaymentSummary.swift	0.00%	35 Missing ⚠️
Views/Payment/PaymentResultPopUp.swift	0.00%	31 Missing ⚠️
App/App_macOS.swift	61.40%	22 Missing ⚠️
Views/Buttons/SupportKiwixButton.swift	0.00%	15 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
- Coverage   37.96%   36.01%   -1.96%     
==========================================
  Files         119      127       +8     
  Lines        6969     7453     +484     
==========================================
+ Hits         2646     2684      +38     
- Misses       4323     4769     +446     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kelson42]

@BPerlakiH I can not merge like this, what is going on with the CI must be properly understood and treated.

[rgaudin]

@BPerlakiH your marchant ID commit 3bee29b fixed the iOS build but not the macOS one. Indeed, it's not clear what's happening and is definitely specific to this PR's changes.

For clarity, I reran the CI workflow on main and it succeeded

[BPerlakiH]

@BPerlakiH your marchant ID commit 3bee29b fixed the iOS build but not the macOS one. Indeed, it's not clear what's happening and is definitely specific to this PR's changes.

For clarity, I reran the CI workflow on main and it succeeded

@rgaudin
I think the reason behind it is that the merchant certificate for Apple Pay is iOS only, can we either extend it to be all platform or create another one for macOS ?

[rgaudin]

OK, I think we're not aligned with what's in this PR. My understanding (@kelson42 please speak up if I'm mistaken) is that this PR should introduce donations on the App (via Apple Pay).

So when merging this, we would have a working donation UI that results in actual donated money on our Stripe account.

Unless I misunderstood, that's not where we're going.

• I believe we must follow Stripe's documentation which entails creating a PaymentIntent on Stripe before asking ApplePay to process it.
• That PaymentIntent will require a Stripe API Key. Here's the test-mode one: pk_test_oglo2v3Wc7ibH2oQe5oUDkhi. You can use Stripe test cards in Stripe-mode but for ApplePay, you must use a real card (wont be charged as long as using the test API key)
• It seems quite clear to me that Stripe+ApplePay is only available on iOS. For macOS, the only option is web via Safari AFAICT. In this regard, we should simply open the donation URL on the browser.
• Stripe doc suggest the paymentIntent to be created from a secure location (a new endpoint on one of our server) so that we can control the amount/currency requested. Given this is not a purchase but a donation and we allow users to select the amount, it sounds like unnecessary complications ATM

Obviously this is from reading Stripe's doc and I have no prior ApplePay experience so there might be other ways.

@BPerlakiH please let me know what you think of this

[BPerlakiH]

Yes, I agree, from what I can see there's a couple of issues to be taken care of.

1. we need the stripe integration in order to actually charge the given card. I tested it with the release build of iOS, and I could add my card to Apple Pay, and use it, but it's not charged, since it's not connecting to stripe (the payment provider).
2. the stripe doc suggest that the for usual e-commerce the price / order tracking should be secured, for us it's not that important, so possibly the back-end integration can be omitted.
3. the build issue remains for macOS. I tried to manually add the Apple Pay capability to the project (not via Xcodegen), and the problem is that I couldn't find a way to filter it down to iOS only as it supports all platforms:

---

[rgaudin]

From what I've seen online, we should be able to remove the entitlement/capability from project and add the merchantID to the Stripe dep config. Have you tried?