Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to load iFrame contents #1028

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

BPerlakiH
Copy link
Collaborator

@BPerlakiH BPerlakiH commented Nov 14, 2024

Fixes: #1027

Screenshot 2024-11-14 at 23 14 55

@kelson42
Copy link
Contributor

CI still broken, putting in draft

@kelson42 kelson42 marked this pull request as draft November 15, 2024 06:26
@kelson42 kelson42 removed this from the 3.6.0 milestone Nov 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 39.03%. Comparing base (7644188) to head (1f91e16).

Files with missing lines Patch % Lines
ViewModel/BrowserViewModel.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
- Coverage   39.03%   39.03%   -0.01%     
==========================================
  Files         119      119              
  Lines        6952     6955       +3     
==========================================
+ Hits         2714     2715       +1     
- Misses       4238     4240       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rgaudin rgaudin marked this pull request as ready for review November 21, 2024 15:11
@rgaudin rgaudin merged commit 5715eb7 into main Nov 21, 2024
4 checks passed
@rgaudin rgaudin deleted the 1027-support-iframes-with-srcdoc branch November 21, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reader does not support iframes with srcdoc attribute
4 participants