Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hack around apple-pay capability for macOS #1046

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #1033

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.08%. Comparing base (53c3477) to head (d4cf6e2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   37.08%   37.08%           
=======================================
  Files         127      127           
  Lines        7451     7451           
=======================================
  Hits         2763     2763           
  Misses       4688     4688           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Contributor

kelson42 commented Dec 8, 2024

@rgaudin I let you review/merge that one

@BPerlakiH BPerlakiH changed the title Remove hack around apple-pay capability for macOS Remove hack around apple-pay capability for macOS part 1 Dec 8, 2024
@BPerlakiH BPerlakiH changed the title Remove hack around apple-pay capability for macOS part 1 Remove hack around apple-pay capability for macOS Dec 8, 2024
@BPerlakiH
Copy link
Collaborator Author

BPerlakiH commented Dec 8, 2024

@rgaudin It's now OK to build based on the CI script from this branch:
https://github.com/kiwix/kiwix-apple/actions/runs/12223511232

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgaudin rgaudin merged commit ada980f into main Dec 9, 2024
7 checks passed
@rgaudin rgaudin deleted the 1033-macOS-apple-pay-single branch December 9, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Apple Pay donations for macOS
4 participants