Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deeplink url opening on macOS #1048

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fix deeplink url opening on macOS #1048

merged 2 commits into from
Dec 12, 2024

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #1044

@BPerlakiH BPerlakiH requested review from rgaudin and kelson42 December 7, 2024 18:32
@BPerlakiH BPerlakiH linked an issue Dec 7, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 37.03%. Comparing base (ada980f) to head (4634ed3).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
App/App_macOS.swift 0.00% 12 Missing ⚠️
SwiftUI/Patches.swift 0.00% 8 Missing ⚠️
Views/ViewModifiers/FileImport.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   37.08%   37.03%   -0.05%     
==========================================
  Files         127      127              
  Lines        7451     7461      +10     
==========================================
  Hits         2763     2763              
- Misses       4688     4698      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 force-pushed the 1044-fix-macOS-deeplinks branch from 976125e to 4634ed3 Compare December 12, 2024 14:14
@kelson42 kelson42 merged commit bd6d1e7 into main Dec 12, 2024
4 checks passed
@kelson42 kelson42 deleted the 1044-fix-macOS-deeplinks branch December 12, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strangely behaving Deeplinks
3 participants