Target FTP forlder for release

[rgaudin]

Fixes #756

[rgaudin]

Note that this only fixes the folder, not the filename. Awaiting @kelson42's input on that

[BPerlakiH]

LGTM

[rgaudin]

I'll update filename as well

[BPerlakiH]

hmm I am not sure about this one...
we rename it, but the upload script still gets the kiwix-${VERSION}.dmg file as the --src input.
Maybe it would be enough to do:

Suggested change

	mv ${PWD}/kiwix-${VERSION}.dmg ${PWD}/kiwix-desktop-macos_${VERSION}.dmg
	python .github/upload_file.py --src ${PWD}/kiwix-${VERSION}.dmg --dest ci@master.download.kiwix.org:30022/data/download/${UPLOAD_FOLDER} --ssh-key ${SSH_KEY}
	mv ${PWD}/kiwix-desktop-macos_${VERSION}.dmg ${PWD}/kiwix-${VERSION}.dmg
	mv ${PWD}/kiwix-${VERSION}.dmg ${PWD}/kiwix-desktop-macos_${VERSION}.dmg
	python .github/upload_file.py --src ${PWD}/kiwix-desktop-macos_${VERSION}.dmg --dest ci@master.download.kiwix.org:30022/data/download/${UPLOAD_FOLDER} --ssh-key ${SSH_KEY}

[rgaudin]

My bad ; fixed it. No we can't pass full destination as the script expects a folder.

[BPerlakiH]

do we need the 2nd mv command after the upload ?

[rgaudin]

This filename is a requirement for this very step only. Changing expectations from this step onward seems unjustified. We dont need it because it's kind of the last step but it's cleaner IMO.

[BPerlakiH]

I think it needs a slight adjustment, as above.

[rgaudin]

I think it needs a slight adjustment, as above.

Which adjustment ?

[BPerlakiH]

I think it needs a slight adjustment, as above.

Which adjustment ?

I think we were commenting on the same simultaneously.
Q: do we need to re-rename the file after the upload ?