773 streaming uncompressed data #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgaudin
requested changes
May 30, 2024
rgaudin
previously approved these changes
May 30, 2024
|
With the latest changes we are reading directly for media type (both audio and video), |
|
@BPerlakiH CI does not pass, and would be better to have a git log cleaner |
|
@BPerlakiH Does it fix #744 too? |
rgaudin
previously approved these changes
Jun 1, 2024
BPerlakiH
dismissed
rgaudin’s stale review
The merge-base changed after approval.
BPerlakiH
force-pushed
the
773-streaming-data
branch
from
ade677e to
7d0e3b8
Compare
|
Yes, it is fixing #744 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #773
Reading the content in "chunks".
Both direct and indirect / ZIM streaming data solution is added.
Currently the ZIM streaming is not in use, until the offset issue is resolved on the libZIM side (see openzim/libzim#886).
There are still issues with syncing the urlScheme closing, and maybe it's worth to add a Task cancelation, when the user leaves the currently loading page.