Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "mailto:" urls to be external #792

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #780

@BPerlakiH BPerlakiH linked an issue Jun 7, 2024 that may be closed by this pull request
@BPerlakiH BPerlakiH changed the title Add mailto url to be external Change "mailto:" urls to be external Jun 7, 2024
@BPerlakiH BPerlakiH requested review from rgaudin and kelson42 June 7, 2024 10:56
@kelson42
Copy link
Contributor

kelson42 commented Jun 7, 2024

@BPerlakiH Is that the right logic!? Everything which is not zim:// should be external IMHO.

We have a few other schemes, for example, tel: geo: ftp:...

@BPerlakiH
Copy link
Collaborator Author

@BPerlakiH Is that the right logic!? Everything which is not zim:// should be external IMHO.

We have a few other schemes, for example, tel: geo: ftp:...

I did found that we handle "geo" scheme separately. Should we say that everything apart from "kiwix" and "geo" is external then ?

@BPerlakiH
Copy link
Collaborator Author

@kelson42 Please see it updated.

@kelson42
Copy link
Contributor

kelson42 commented Jun 8, 2024

@BPerlakiH This looks more what I was expacted. From a user perspective, its important the OS tries to open the link with the appropriate app, in the case of mailto: the default mail app.

Here a few remarks which are related to the naming of things:

  • We should have a zim:// protocol, not a kiwix:// protocol, can we change that in a dedicated issue/PR?
  • I challenge the "external" naming, probably "unsupported" would be better?

@BPerlakiH
Copy link
Collaborator Author

BPerlakiH commented Jun 8, 2024

The "mailto:" is opening the mail app, I've tested that (on macOS).
I've opened an issue for the url scheme change: #798
Changed the naming from "isExternal" to "isUnsupported".

@kelson42 kelson42 merged commit 167e2c3 into main Jun 9, 2024
4 checks passed
@kelson42 kelson42 deleted the 780-mailto-links-are-not-opening-the-os-configured-mail-application branch June 9, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mailto: links are not opening the OS-configured mail application
2 participants