-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "mailto:" urls to be external #792
Change "mailto:" urls to be external #792
Conversation
@BPerlakiH Is that the right logic!? Everything which is not zim:// should be external IMHO. We have a few other schemes, for example, tel: geo: ftp:... |
I did found that we handle "geo" scheme separately. Should we say that everything apart from "kiwix" and "geo" is external then ? |
@kelson42 Please see it updated. |
@BPerlakiH This looks more what I was expacted. From a user perspective, its important the OS tries to open the link with the appropriate app, in the case of mailto: the default mail app. Here a few remarks which are related to the naming of things:
|
The "mailto:" is opening the mail app, I've tested that (on macOS). |
Fixes: #780